Fix CRAN testing issues with R-devel #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two issues we had with CRAN testing our 0.3.0 submission.
test_x64 for some Windows cases
We had the following ERROR in our 0.3.0 submission to CRAN for Windows.
This is because we aren't catch the
test_x64
case, which seems to be when Windows is using 64-bit R and explicitly calling it out in the directory names.From
R CMD check
:Updating .BuildTestLib to use R.home
Below is a reproduced error that we also got from CRAN testing on R-devel.
I'm not entirely sure what the problem was. I was able to reproduce this error just straight up
R CMD INSTALL
-ingmilne
on the R-devel docker image, thoughRD CMD INSTALL
did not have any problem. This made me realize that.BuildTestLib
is hard-coded to useR
even forRD CMD CHECK
.Instead, we use
file.path(R.home("bin"), "R")
to look up the binary for the current R process. So if you call from an RD process, you will get the correct path to the r-devel binary.https://stackoverflow.com/questions/33798115/command-to-see-r-path-that-rstudio-is-using