Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The package in focus should be colored differently in Dependency graph #239

Closed
jameslamb opened this issue Jul 29, 2019 · 1 comment
Closed

The package in focus should be colored differently in Dependency graph #239

jameslamb opened this issue Jul 29, 2019 · 1 comment
Labels
enhancement good first issue help wanted

Comments

@jameslamb
Copy link
Collaborator

Inspired by #238 ...I also think the package in focus should be colored differently in the output of DependencyReporter. So for example, if I runCreatePackageReport("uptasticsearch") with a DependencyReporter, the uptasticsearch node should be a different color than all its dependencies, for similar reasons to #238 . Since I can't factor my own package out of its dependency graph, I should be able to visually disregard it.
@jameslamb jameslamb mentioned this issue Jul 29, 2019
Closed
@jameslamb jameslamb mentioned this issue Sep 24, 2019
Merged
@bburns632 bburns632 mentioned this issue Oct 1, 2019
Closed
jayqi pushed a commit that referenced this issue Jul 21, 2020
@jameslamb
added node coloring in DependencyReporter (fixes #238, #239) (#243)
330f379 
* added node coloring in DependencyReporter

* why does this not work

* ugh

* refactored plotting

* added notes on color scheme

* updated color choices for DependencyReporter

* Added legend and cleaned up left-behind code

* more changes

* replace delete Rmd and undo unrelated formatting sttuff

* update text about colors
@jameslamb
Copy link
Collaborator Author

oh I think this is fixed by #243 !

After pulling master and installing from there, this is the result of pkgnet::CreatePackageReport('devtools'), zoomed in so you can see the node labels

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameslamb @bburns632