Fixed bug in InheritanceReporter that errored due to external parent …

…classes
uptake · Dec 4, 2018 · 46f0043 · 46f0043
1 parent 3716dec
commit 46f0043
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/R/PackageInheritanceReporter.R b/R/PackageInheritanceReporter.R
@@ -194,7 +194,12 @@ InheritanceReporter <- R6::R6Class(
                     }
                 }
 
+                # Combine all edges together
                 edgeDT <- data.table::rbindlist(edgeList)
+
+                # Filter out any parents that are external to the package
+                edgeDT <- edgeDT[TARGET %in% nodeDT[, node]]
+
                 private$cache$edges <- edgeDT
 
             }

diff --git a/inst/milne/R/The_Friend.R b/inst/milne/R/The_Friend.R
@@ -41,5 +41,5 @@ RightAnswer <- setRefClass(
 # @description Incorrect Answer to a Question
 WrongAnswer <- setRefClass(
     Class = "WrongAnswer",
-    contains = "PoohAnswer"
+    contains = c("PoohAnswer", "numeric")
 )