Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing write lock contents #107

Merged
merged 2 commits into from
Sep 18, 2019
Merged

Testing write lock contents #107

merged 2 commits into from
Sep 18, 2019

Conversation

jeffrey-a-meunier
Copy link
Contributor

Added two tests: one to ensure that a specified string is written to the writeLock file, and another to ensure that nothing is written to the readLock file.

@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #107 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #107      +/-   ##
============================================
+ Coverage      89.5%   89.69%   +0.19%     
- Complexity      717      722       +5     
============================================
  Files            56       56              
  Lines          2677     2688      +11     
  Branches        176      177       +1     
============================================
+ Hits           2396     2411      +15     
+ Misses          195      192       -3     
+ Partials         86       85       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/upserve/uppend/FileStore.java 83.67% <100%> (+0.81%) 38 <0> (+1) ⬆️
...main/java/com/upserve/uppend/FileStoreBuilder.java 100% <100%> (ø) 33 <2> (+2) ⬆️
...ain/java/com/upserve/uppend/lookup/LookupData.java 95.35% <0%> (+1.42%) 85% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8e6fa...75877e8. Read the comment docs.

Copy link
Contributor

@dstuebe dstuebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jeffrey-a-meunier jeffrey-a-meunier merged commit a5cbe7f into master Sep 18, 2019
@dstuebe dstuebe deleted the write_lock_contents branch September 18, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants