Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file descriptor leak in Files.list method. Stream must be closed. #104

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

dstuebe
Copy link
Contributor

@dstuebe dstuebe commented Aug 26, 2019

Bug Fix:

  • Close Files.list stream which leaks open file descriptor if the stream is not closed.

@codecov-io
Copy link

Codecov Report

Merging #104 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #104      +/-   ##
============================================
+ Coverage     89.65%   89.72%   +0.07%     
- Complexity      719      720       +1     
============================================
  Files            56       56              
  Lines          2677     2677              
  Branches        176      176              
============================================
+ Hits           2400     2402       +2     
+ Misses          192      191       -1     
+ Partials         85       84       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/upserve/uppend/FileStore.java 82.85% <100%> (ø) 37 <1> (ø) ⬇️
...ain/java/com/upserve/uppend/lookup/LookupData.java 96.07% <0%> (+0.71%) 86% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8515f69...6289f63. Read the comment docs.

@dstuebe dstuebe merged commit 7d8e6fa into master Aug 26, 2019
@dstuebe dstuebe deleted the file_descriptor_leak branch August 26, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants