Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs, cache size and formatting #101

Merged
merged 6 commits into from
Aug 9, 2019
Merged

Docs, cache size and formatting #101

merged 6 commits into from
Aug 9, 2019

Conversation

dstuebe
Copy link
Contributor

@dstuebe dstuebe commented Aug 9, 2019

Changes:

  • Add jitpack badge to readme
  • Increase the size of the metadata lookup key cache
  • Format metrics value to zero rather than LongMin when empty

TODO:

  • Make metadata cache size configurable

jeffrey-a-meunier
jeffrey-a-meunier reviewed Aug 9, 2019
View reviewed changes
src/main/java/com/upserve/uppend/lookup/LookupMetadata.java
@@ -32,7 +30,7 @@
public class LookupMetadata {
private static final Logger log = org.slf4j.LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());

private static final int MAX_BISECT_KEY_CACHE_DEPTH = 9; // Size == 1024
private static final int MAX_BISECT_KEY_CACHE_DEPTH = 13; // Size == 16_384
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 ^ 13 = 8192

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array size is 2^(n+1)

jeffrey-a-meunier
jeffrey-a-meunier approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@jeffrey-a-meunier jeffrey-a-meunier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise approve.

@dstuebe dstuebe merged commit d9ddb49 into master Aug 9, 2019
@dstuebe dstuebe deleted the docs branch August 19, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffrey-a-meunier jeffrey-a-meunier jeffrey-a-meunier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstuebe @jeffrey-a-meunier