Fixed LookupMetadata hit/miss counts #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initialize a new (or *many* new) LookupMetadata instances.
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
===========================================
+ Coverage 87.91% 89.61% +1.7%
- Complexity 684 719 +35
===========================================
Files 52 56 +4
Lines 2259 2678 +419
Branches 171 176 +5
===========================================
+ Hits 1986 2400 +414
- Misses 185 193 +8
+ Partials 88 85 -3
Continue to review full report at Codecov.
|
dstuebe
reviewed
Jul 31, 2019
dstuebe
reviewed
Jul 31, 2019
dstuebe
reviewed
Jul 31, 2019
|
I'll start working on the test cases now. |
dstuebe
reviewed
Aug 2, 2019
| if (luckyMe) { | ||
| result = loadMetadata(); | ||
| // a reloadInterval of 0 prevents reloading of the metadata | ||
| boolean reloadMetadata = !reloadStamp.compareAndSet(stamp[0], stamp[0] + reloadInterval); |
There was a problem hiding this comment.
Let's test this a bunch.
We need to figure out how to hit both the elapsed time condition and the first thread to compare and set...
that all calls to findKey are properly accounted.
for LookupData.getMetadata().
dstuebe
reviewed
Aug 6, 2019
mocked instances. Also inverted the reloadMetadata flag in the getMetadata method.
| write(pos, byteRecord(bytes)); | ||
| if (log.isTraceEnabled()) log.trace("appended {} bytes to {} at pos {}", bytes.length, virtualFileNumber, pos); | ||
| blobStoreMetricsAdders.appendCounter.increment(); |
There was a problem hiding this comment.
How much might using these counters affect performance?
There was a problem hiding this comment.
Curious to see what total time is for LongAdder.increment in JProfiler...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to use an existing LookupMetadata instance to initialize a new (or many new) LookupMetadata instances.