Minor UI changes #20
Merged
Minor UI changes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #20 +/- ##
===========================================
+ Coverage 86.79% 86.88% +0.08%
===========================================
Files 71 71
Lines 2204 2218 +14
Branches 114 115 +1
===========================================
+ Hits 1913 1927 +14
- Misses 274 275 +1
+ Partials 17 16 -1
Continue to review full report at Codecov.
|
kjagiello
requested changes
Feb 20, 2017
src/shop/models.py
Outdated
| @@ -256,7 +256,8 @@ class Product(UUIDModel, TimeStampedModel): | |||
| active = models.BooleanField(default=True) | |||
|
|
|||
| # cached quantity | |||
| qty = models.IntegerField(default=0) | |||
| qty = models.IntegerField(verbose_name='quantity', default=0) | |||
There was a problem hiding this comment.
The verbose name needs to be internationalised.
src/wallet/models.py
Outdated
| @@ -93,3 +100,7 @@ def countable(self): | |||
| else: | |||
| return self.trx_status in [enums.TrxStatus.PENDING, | |||
| enums.TrxStatus.FINALIZED] | |||
|
|
|||
| class Meta: | |||
| verbose_name = 'Transaction' | |||
There was a problem hiding this comment.
The verbose names need to be internationalised (check all the instances in this file).
kjagiello
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.