Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to do manual stock-taking #17

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Ability to do manual stock-taking #17

merged 2 commits into from
Feb 16, 2017

Conversation

kjagiello
Copy link
Member

No description provided.

@kjagiello kjagiello added this to the 2.0.0 milestone Feb 13, 2017
@kjagiello kjagiello self-assigned this Feb 13, 2017
@flaeppe
Copy link
Member

flaeppe commented Feb 14, 2017

When we assign a free stock take chunk(assign_free_stocktake_chunk(user_id, stocktake_id)), is a chunk_obj with an owner considered free?

Because now it seems that we can overwrite the owner_id of it, when someone is not finished yet.

Wouldn't in that case this filter make more sense?:
chunk_qs.filter(stocktake_id=stocktake_id, locked=False, owner__isnull=True)

Or am I missing something?

@kjagiello
Copy link
Member Author

Nice catch! That's definitely a bug!

@kjagiello kjagiello force-pushed the feature/stocktaking branch 2 times, most recently from 13a4232 to ced4ab3 Compare February 14, 2017 07:47
@kjagiello kjagiello merged commit 7f94e32 into develop Feb 16, 2017
@kjagiello kjagiello deleted the feature/stocktaking branch February 21, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaeppe flaeppe Awaiting requested review from flaeppe

@ElinSwedin ElinSwedin Awaiting requested review from ElinSwedin

Assignees

@kjagiello kjagiello

Labels
enhancement
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kjagiello @flaeppe