Consider cancelled tasks as checked #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also hope for this feature! |
julianmateu
commented
Oct 23, 2024
| @@ -10,6 +10,7 @@ export class Todo { | |||
| // suffix: '] ' | |||
| // body: hello | |||
| private static readonly regexp = /^(?<prefix>((> ?)*)?\s*[\-\*][ ]+\[)(?<check>.)(?<suffix>\]\s+)(?<body>.*)$/; | |||
| private static readonly checkedStatuses = ['x', '-']; | |||
There was a problem hiding this comment.
To make it customisable as it is, this would have to either
- be passed from the controller somehow, this will cause the setting to be passed around through every function call.
- it should access the global settings from the model. This won't work, as the model does not depend on Obsidian, and when importing
{ SETTINGS } from 'settings'tests will fail
None of these is an acceptable solution, so I decided to leave this as a hardcoded list.
|
@uphy any thoughts? |
|
I'm sorry for the delay in reviewing. I think this is a very good implementation that is both necessary and sufficient. related: #208 @8bitbuddhist Though this implementation will not ignore the IN_PROGRESS status ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84 (partially, only adds cancelled tasks and it is not customizable).
I tried making it customizable via settings, but I think I'm not following the convention on the different classes, so I think it's better to just ship this PR first and address customisation separately.