Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the project work #6

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Make the project work #6

merged 2 commits into from
Nov 8, 2024

Conversation

negz
Copy link
Member

@negz negz commented Nov 8, 2024

Description of your changes

Closes #5

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Testing in progress...

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
Copy link
Member

@adamwg adamwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Signed-off-by: Nic Cope <nicc@rk0n.org>
@negz negz merged commit 59174f9 into upbound:main Nov 8, 2024
1 check passed
@negz negz deleted the haarchri-fixes branch November 8, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants