Skip to content

Commit

Permalink
change enum filename generated not uppercase but as used in typescript
Browse files Browse the repository at this point in the history
  • Loading branch information
up94 authored and Angelo Manganiello committed Dec 31, 2019
1 parent 9c3a7a9 commit 1fe6719
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
5 changes: 3 additions & 2 deletions generators/entity-server/files.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
const _ = require('lodash');
const constants = require('../generator-nodejs-constants');

const SERVER_NODEJS_DIR = `${constants.SERVER_NODEJS_SRC_DIR}/`;
Expand Down Expand Up @@ -50,11 +51,11 @@ function writeFiles() {

this.fields.forEach(field => {
if (field.fieldIsEnum === true) {
const fieldType = field.fieldType;
const enumFileName = _.kebabCase(field.fieldType);
const enumInfo = utils.buildEnumInfo(field, this.angularAppName, this.packageName, this.clientRootFolder);
this.template(
`${SERVER_NODEJS_DIR}src/domain/enumeration/Enum.ts.ejs`,
`${SERVER_NODEJS_DIR}src/domain/enumeration/${fieldType}.ts`,
`${SERVER_NODEJS_DIR}src/domain/enumeration/${enumFileName}.ts`,
this,
{},
enumInfo
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ import {validate, Contains, IsInt, Length, IsEmail, IsFQDN, IsDate, Min, Max} fr
<%_ Object.keys(uniqueEntities).forEach(function(entityClass) { _%>
import <%= entityClass %> from './<%= uniqueEntities[entityClass] %>.entity';
<%_ }); _%>
<%_ Object.keys(uniqueEnums).forEach(function(element) { _%>
import { <%= element %> } from './enumeration/<%= element %>';
<%_ Object.keys(uniqueEnums).forEach(function(enumClass) { _%>
import { <%= enumClass %> } from './enumeration/<%= uniqueEnums[enumClass] %>';
<%_ }); _%>

<%_ if (typeof javadoc == 'undefined') { _%>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ for (idx in relationships) {
for (idx in fields) {
if (fields[idx].fieldIsEnum && (
!uniqueEnums[fields[idx].fieldType] || (uniqueEnums[fields[idx].fieldType] && fields[idx].fieldValues.length !== 0))) {
uniqueEnums[fields[idx].fieldType] = fields[idx].fieldType;
uniqueEnums[fields[idx].fieldType] = _.kebabCase(fields[idx].fieldType);
}
}
Expand Down
5 changes: 4 additions & 1 deletion test/entity.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ describe('Subgenerator entity of nodejs JHipster blueprint', () => {
// Adds your tests here
assert.file('.jhipster/GreatEntity.json');

const genderEnumPath = `${SERVER_NODEJS_DIR}src/domain/enumeration/Gender.ts`;
const genderEnumPath = `${SERVER_NODEJS_DIR}src/domain/enumeration/gender.ts`;
const greatEntityPath = `${SERVER_NODEJS_DIR}src/domain/great-entity.entity.ts`;

assert.file(genderEnumPath);
Expand All @@ -80,6 +80,9 @@ describe('Subgenerator entity of nodejs JHipster blueprint', () => {
// Gender enum class
assert.fileContent(genderEnumPath, 'export enum Gender');

// import enum in entity
assert.fileContent(greatEntityPath, "import { Gender } from './enumeration/gender';");

// name UUID unique field
assert.fileContent(greatEntityPath, "@Column({ name: 'name', unique: true })");
assert.fileContent(greatEntityPath, 'name: string;');
Expand Down

0 comments on commit 1fe6719

Please sign in to comment.