Code refactoring as follow up to recent BlockchainType changes #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rommex
approved these changes
Jul 17, 2024
| bio == nil && | ||
| location == nil && | ||
| website == nil | ||
| guard avatarData == nil else { return false } |
| return (token == CryptoSender.SupportedToken.eth && chainSpec.chain.identifyBlockchainType() == .Ethereum) || | ||
| (token == CryptoSender.SupportedToken.matic && chainSpec.chain.identifyBlockchainType() == .Matic) || | ||
| (token == CryptoSender.SupportedToken.eth && chainSpec.chain.identifyBlockchainType() == .Base) | ||
| switch (token, chainSpec.chain.identifyBlockchainType()) { |
rommex
added a commit
that referenced
this pull request
Jul 26, 2024
* development: (35 commits) bumped version to 5.3.5(3) MOB-2119 - Maintenance mode (#616) MOB-2129 - Fixed occasional camera crash (#615) MOB-2111 - Fixed UI and copies in activity filters (#614) MOB-2126 - Support ethTransaction for ULW (#613) MOB-2111 - Activities filter (#612) MOB-2107 Fix Ledger Live to be discoverable (#611) Code refactoring as follow up to recent BlockchainType changes (#610) bumped version to 5.3.5 (2) MOB-2097 Blockchains refactoring (#608) Switch to Profiles API for domain name resolution (#609) MOB-2104 - Fixed messaging nav title visibility (#606) MOB-2104 - Fixed messaging nav bar when search is active (#605) MOB-2058 - Revise copy and move Login CTA (#604) MOB-2106 - Removed Spot wallet from the list of supported (#603) MOB-2104 - Enable Apps Inbox for ULW (#602) MOB-2103 - Do not auto-enable groups messaging profile for ULW (#601) MOB-2060 Send crypto on Base chain (#579) MOB-2102 - Handle unsupported WC requests for ULW (#600) Fixed tests target (#599) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.