-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOB-2076 - Handle USDC asset in ULW #583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rommex
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With removal of hard coded strings
} | ||
|
||
/// Adjust appearance of Base coin specifically. | ||
if blockchainAsset.symbol == "ETH", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No hard coded strings please:
BlockchainType.Ethereum.rawValue
baseChainSymbol
rommex
approved these changes
Jun 21, 2024
rommex
added a commit
that referenced
this pull request
Jun 21, 2024
* development: MOB-2028 - Purchase UW (#575) MOB-2076 - Handle USDC asset in ULW (#583) Always show MATIC USDC in the list of tokens. (#585) MOB-2074 - Update ULW name and appearance in the list (#584) MOB-2053 Remove Legacy Wallets handling (#578) Stopping the AV Session on a detached thread (#582) MOB-2073 - Updated Fireblocks SDK (#581) MOB-2069 - Copy update for ULW removal (#580)
rommex
added a commit
that referenced
this pull request
Jul 4, 2024
…/MOB-2060-Send-Crypto-on-Base-chain * commit '9bf5bc72c5ae8c7aeeb6f0d19c0b075e46cf5ec1': (24 commits) Fixed tests target (#599) Update WC SDK to 1.19.4 (#598) MOB-2092 - Fixed copies and domain resolution (#597) MOB-2098 - Show all available ULW tokens in share screen (#596) Tx display info refactoring (#595) Disable LD noisy logs MOB-2092 - Created UI to show TX details (#594) MOB-2086 - Update Fireblocks SDK to v. 2.6.0 (#593) MOB-2090 - Fixing WC requests pull ups UI (#592) MOB-2083 - Support sign typed data via ULW (#591) changed to Float (#590) added 'eth_signTypedData_v4' to optional methods Fixed raw wallet address input formatting (#589) Let users send crypto to themself (#587) MOB-2078 - Fixed regex pattern validation (#588) MOB-2078 - Support sending to none EVM addresses like SOL and BTC for ULW (#586) MOB-2028 - Purchase UW (#575) MOB-2076 - Handle USDC asset in ULW (#583) Always show MATIC USDC in the list of tokens. (#585) MOB-2074 - Update ULW name and appearance in the list (#584) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.