Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated button title when vaulted domains discovered #434

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

Oleg-Pecheneg
Copy link
Contributor

No description provided.

@Oleg-Pecheneg Oleg-Pecheneg requested a review from rommex March 13, 2024 02:22
@@ -96,7 +96,7 @@ private extension ParkedDomainsFoundViewController {
addProgressDashesView()
setupCollectionView()
title = presenter.title
importButton.setTitle(String.Constants.import.localized(), image: nil)
importButton.setTitle(String.Constants.viewVaultedDomains.localized(), image: nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice )

@@ -96,7 +96,7 @@ private extension ParkedDomainsFoundViewController {
addProgressDashesView()
setupCollectionView()
title = presenter.title
importButton.setTitle(String.Constants.import.localized(), image: nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to remove the import constant?

@Oleg-Pecheneg Oleg-Pecheneg merged commit dfb2c13 into development Mar 13, 2024
@Oleg-Pecheneg Oleg-Pecheneg deleted the dev/feat/import-button branch March 13, 2024 08:11
rommex added a commit that referenced this pull request Mar 15, 2024
* development:
  Adjusted buy crypto pull up
  MOB-1889 - Buy crypto (#443)
  MOB-1887 - Start pull data timer if wallet has minting domains (#442)
  MOB-1882 - Show ENS domain profile if no UD available (#440)
  MOB-1856 - Fixed token logos inconsistency and added tokens sorting on public profile (#439)
  MOB-1884 Update WC wallet registry (#441)
  MOB-1866 - Updated explore search bar prompt (#438)
  MOB-1869 - Fixed number of followers after user follow/unfollow (#437)
  Updated button title when vaulted domains discovered (#434)
  MOB-1881 - Track SOL and BTC balances if added in profile (#436)
  MOB-1880 - Use OKLink to view wallets and transactions (#435)
  MOB-1836 - Explore feature (#433)
  MOB-1773 - Fixed blocking of users in chat (#429)
  Use acquired date for sorting collectibles as most recent (#428)
  MOB-1871 - Fixed issue when user couldn't login with website account during onboarding. (#426)
  MOB-1868 Check former dependencies on Zesame (ZIL) (#419)
  fixed dependency on the removed Zesame lib in Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants