Greetings5.0 content #386
Merged
Greetings5.0 content #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Couple of notes:
- It is safe to remove ScrollView (line 19) because content will fit on smallest device.
- After switching to this branch i couldn't find actual icons in Assets folder. Even though they're compiled and added to git, could you please double-check it on your side?
Comment on lines
77
to
79
| .squareFrame(40) | ||
| .foregroundStyle(hint.iconTint) | ||
| .padding(EdgeInsets(top: 8, leading: 8, bottom: 8, trailing: 8)) |
There was a problem hiding this comment.
On the mockups the icon's size is 24 pt and there's 8pt padding to each side. It is better to export image in Figma without padding and keep code as it was.
Comment on lines
157
to
165
| static let introSwitcherTitle = "INTRO_SWITCHER_TITLE" | ||
| static let introBalanceTitle = "INTRO_BALANCE_TITLE" | ||
| static let introCollectiblesTitle = "INTRO_COLLECTIBLES_TITLE" | ||
| static let introMessagesTitle = "INTRO_MESSAGES_TITLE" | ||
|
|
||
| static let introSwitcherBody = "INTRO_SWITCHER_BODY" | ||
| static let introBalanceBody = "INTRO_BALANCE_BODY" | ||
| static let introCollectiblesBody = "INTRO_COLLECTIBLES_BODY" | ||
| static let introMessagesBody = "INTRO_MESSAGES_BODY" |
There was a problem hiding this comment.
Duplicate of String.Constants?
Oleg-Pecheneg
approved these changes
Feb 16, 2024
rommex
added a commit
that referenced
this pull request
Feb 16, 2024
* development: Mob 1832 tokens from diff layers are confused (#389) MOB-1833 - Fixed issue when wallet header could disppear sometimes (#387) RR view improvements (#388) Greetings5.0 content (#386) fixed the trigger logic for Greetings5.0 Removed default value to tokens Track token pct change Show greetings view if needed Created greetings view. Added verification and set flag about user upgraded to wallet feature Fixed issue when user could select rr domain to be rr domain MOB-1746 - Wallet functionality (#385) MOB-1785 - Fixed pull up UI (#372) HOTFIX: corrected parameters for the second request attempt MOB-1783 Handle the Profile API requests reduction (#364) update + minor change of API (#363) MOB-1676 Fix custom url links from dApps (#361) MOB-1773 - Block user in group (#359) # Conflicts: # unstoppable-ios-app/domains-manager-ios.xcodeproj/project.pbxproj - RESOLVED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.