-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update querystringify to 2.1.1 to fix core bug with uncaught exception #175
Comments
Also see unshiftio/querystringify#26 |
Basically you can crash Node apps that use this package server-side in middleware by passing |
It's worth noting that the URL-parse library is designed to allow custom query string parsers instead of the bundled querystringify. So if the primary use-cases is usage on Node.js, and want better unescape fallback for the query strings it might be an option to do this. |
@3rd-Eden could you add a deprecation notice please? I just checked and there wasn't one there yet. npm deprecate url-parse@"<1.4.7" "Please upgrade to v1.4.7+ as an uncaught exception bug in querystringify has been fixed and may cause a vulnerability in server-side route middleware" |
v2.1.1 of querystringify was released which fixes an issue where it does not match Node's graceful fallback for decoding URI
unshiftio/querystringify@30e1d19
per Node's built-in:
https://nodejs.org/api/querystring.html#querystring_querystring_unescape_str
The text was updated successfully, but these errors were encountered: