Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Node's safe decode alternative #26

Closed
niftylettuce opened this issue Apr 24, 2019 · 1 comment
Closed

Implement Node's safe decode alternative #26

niftylettuce opened this issue Apr 24, 2019 · 1 comment

Comments

@niftylettuce
Copy link

We should try to match Node behavior in the browser, and to do so, instead of returning null, we'd need to implement Node's fallback:

https://github.com/nodejs/node/blob/908292cf1f551c614a733d858528ffb13fb3a524/lib/querystring.js#L397-L403 which specifically uses https://github.com/nodejs/node/blob/908292cf1f551c614a733d858528ffb13fb3a524/lib/querystring.js#L67-L108

@lpinca
Copy link
Member

lpinca commented Apr 25, 2019

FWIW I think compatibility with Node.js querystring module has never been an objective. This module does not even handle arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants