Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update creating-custom-controls.md #19018

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Dec 5, 2024

GitHub Issue (If applicable): n/a

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

defining own ResourceDictionary I stumbled over this detail:
https://platform.uno/docs/articles/guides/creating-custom-controls.html
in the text the generic.xaml is lowercase and in the code sample its uppercase. I read somewhere (might be another uno doc page?) that especially for mobile devices the casing is important detail, because if its uppercase, they would not be able to use it. if thats true, this doc page should be updated to recommend lowercase instead in my opinion

What is the new behavior?

unified the casing of "Themes/Generic.xaml" mentioned in this page.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

https://discord.com/channels/1182775715242967050/1182775715729526908/1314231281453760613

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19018/index.html

@Xiaoy312 Xiaoy312 merged commit 7801e28 into master Dec 6, 2024
16 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20241205/quick-typo-patch branch December 6, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants