-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update include-mainpage-xaml.md to updated xaml code #18945
Conversation
This code is changed to the code generated using the template. Unless it is causing a build error on the old code.
|
Thank you for your contribution, @0xharkirat! Can you please reword (https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message) your commit to follow the Conventional commits standard? https://www.conventionalcommits.org/en/v1.0.0/ Thank you 😇 |
xmlns:uen="using:Uno.Extensions.Navigation.UI" | ||
xmlns:utu="using:Uno.Toolkit.UI" | ||
xmlns:um="using:Uno.Material" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see these namespaces being used.
Hi @0xharkirat, I just created a new Uno app following the instructions in the Counter tutorial, and everything seems to be working correctly on my end. Could you double-check to ensure you used the For reference the <Page x:Class="Counter.MainPage"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:local="using:Counter"
Background="{ThemeResource ApplicationPageBackgroundThemeBrush}">
<ScrollViewer>
<Grid>
<StackPanel
HorizontalAlignment="Center"
VerticalAlignment="Center">
<TextBlock AutomationProperties.AutomationId="HelloTextBlock"
Text="Hello Uno Platform!"
HorizontalAlignment="Center" />
</StackPanel>
</Grid>
</ScrollViewer>
</Page> |
Oh, I was creating the app from the recommended preset (not the blank one). I think then this request is unnecessary. I can close this one. |
Hi @0xharkirat, thank you for the confirmation. Yes, the Counter tutorial documentation mentions using the |
This code is changed to the code generated using the template. Unless it is causing a build error on the old code.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
It is causing a build error like this:

What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):