Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Responsive markup extension #926

Merged
merged 10 commits into from
Dec 5, 2023
Merged

feat: Responsive markup extension #926

merged 10 commits into from
Dec 5, 2023

Conversation

silviuo
Copy link
Contributor

@silviuo silviuo commented Nov 22, 2023 •
edited
Loading

GitHub Issue (If applicable):
closes https://github.com/unoplatform/uno.chefs/issues/723

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Currently, there is no clean and concise way to handle responsive layouting with XAML. The main way of accomplishing this is through Visual States and AdaptiveTriggers.

What is the new behavior?

This PR introduces a custom markup extension called ResponsiveExtension that allows for any property to be dynamically set.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@silviuo silviuo requested review from Xiaoy312 and kazo0 November 22, 2023 21:45
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

@silviuo silviuo force-pushed the dev/siob/responsive-markup-extension branch from 5091e2d to a241159 Compare November 27, 2023 20:35
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

@silviuo silviuo force-pushed the dev/siob/responsive-markup-extension branch from e1a0b14 to 28eb6bc Compare November 28, 2023 19:31
@silviuo silviuo marked this pull request as ready for review November 28, 2023 19:33
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

Xiaoy312
Xiaoy312 reviewed Nov 28, 2023
View reviewed changes
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

@silviuo silviuo force-pushed the dev/siob/responsive-markup-extension branch from 53cf6d8 to 044e0d1 Compare November 29, 2023 16:54
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

kazo0
kazo0 reviewed Nov 29, 2023
View reviewed changes
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
@silviuo silviuo force-pushed the dev/siob/responsive-markup-extension branch from 044e0d1 to 8d4a202 Compare November 30, 2023 17:13
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

This was referenced Dec 4, 2023
Closed
Closed
@kazo0 kazo0 enabled auto-merge (squash) December 4, 2023 14:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-926.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 747e368 into main Dec 5, 2023
23 checks passed
@kazo0 kazo0 deleted the dev/siob/responsive-markup-extension branch December 5, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 left review comments

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silviuo @Xiaoy312 @kazo0 @eriklimakc