Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port 5.0 changes #903

Merged
merged 10 commits into from
Nov 6, 2023
Merged

Forward port 5.0 changes #903

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c778398
chore: Update to latest stable packages
jeromelaban Oct 29, 2023
5171085
chore: Disable failing test
jeromelaban Oct 29, 2023
cc540f8
chore: Disable tests
jeromelaban Oct 29, 2023
b94c0f9
chore: disable failing test
jeromelaban Oct 29, 2023
a6254eb
chore: disable tests
jeromelaban Oct 29, 2023
82a9181
Restore disabled tests
jeromelaban Oct 29, 2023
dc5fd81
chore: Bump to latest uno
jeromelaban Oct 31, 2023
2505bc1
chore: Update to latest stable packages
jeromelaban Oct 31, 2023
2b4b755
chore: Adjust for backport
jeromelaban Nov 6, 2023
7a4b937
chore: Backport update
jeromelaban Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Disable tests 
#887
  • Loading branch information
@jeromelaban
jeromelaban committed Nov 6, 2023
commit cc540f8c914bf499201351895af39c32a67208b0
3 changes: 2 additions & 1 deletion src/Uno.Toolkit.RuntimeTests/Tests/NavigationBarTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ public async Task NavigationBar_Renders_MainCommand()
#endif

[TestMethod]
[DataRow(MainCommandMode.Back, DisplayName = nameof(MainCommandMode.Back))]
// Disabled https://github.com/unoplatform/uno.toolkit.ui/issues/887
// [DataRow(MainCommandMode.Back, DisplayName = nameof(MainCommandMode.Back))]
[DataRow(MainCommandMode.Action, DisplayName = nameof(MainCommandMode.Action))]
public async Task MainCommand_In_Popup_Without_Page(MainCommandMode mainCommandMode)
{
Expand Down
4 changes: 3 additions & 1 deletion src/Uno.Toolkit.RuntimeTests/Tests/TabBarTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ double GetMinCalculatedDimen()
}

[TestMethod]
[Ignore("Disabled https://github.com/unoplatform/uno.toolkit.ui/issues/887")]
public async Task Verify_Indicator_Display_On_Selection()
{
if (!ImageAssertHelper.IsScreenshotSupported())
Expand Down Expand Up @@ -333,7 +334,8 @@ TabBarItem CreateItem()

[TestMethod]
[DataRow(IndicatorPlacement.Above, DisplayName = "Verify Indicator Above")]
[DataRow(IndicatorPlacement.Below, DisplayName = "Verify Indicator Below")]
// Disabled https://github.com/unoplatform/uno.toolkit.ui/issues/887
// [DataRow(IndicatorPlacement.Below, DisplayName = "Verify Indicator Below")]
public async Task Verify_Indicator_Placement(IndicatorPlacement placement)
{
var item = new TabBarItem
Expand Down