Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust NativeFramePresenter to work with new TemplatedParent #1266

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Oct 14, 2024

GitHub Issue (If applicable): unoplatform/uno#18401

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

OnTemplatedParentChanged no longer triggers

What is the new behavior?

Use Loaded event instead

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@MartinZikmund MartinZikmund self-assigned this Oct 14, 2024
@kazo0 kazo0 enabled auto-merge (squash) October 14, 2024 13:52
@kazo0 kazo0 merged commit f704393 into main Oct 14, 2024
27 checks passed
@kazo0 kazo0 deleted the dev/mazi/templatedparent-frame branch October 14, 2024 15:03
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.5

Copy link
Contributor

mergify bot commented Oct 14, 2024

backport release/stable/5.5

❌ No backport have been created

  • Backport to branch release/stable/5.5 failed

GitHub error: Branch not found

@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/6.3

Copy link
Contributor

mergify bot commented Oct 15, 2024

backport release/stable/6.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 15, 2024
jeromelaban added a commit that referenced this pull request Oct 15, 2024
….3/pr-1266

fix: Adjust `NativeFramePresenter` to work with new `TemplatedParent` (backport #1266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants