fix: UWP Build #1263
Closed
fix: UWP Build #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiaoy312
reviewed
Oct 10, 2024
| @@ -1,13 +1,16 @@ | |||
| using System; | |||
| // FindFirstDescendent is not available in UWP | |||
There was a problem hiding this comment.
in toolkit, use GetFirstDescendent which is an any-plat impl
the Find... from uno.ui is uno-only
There was a problem hiding this comment.
either case, this seems wrong way to fix the problem?
There was a problem hiding this comment.
Small note here, FindFirstDescendent from Uno.UI is both Uno + WinAppSDK (when Uno.WinUI package is referenced) (but not available in Windows UWP)
|
Closing this PR, please refer to this new PR instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Fixes UWP Build
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):