Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

material navigationBar's default back arrow #1228

Merged
merged 1 commit into from
Sep 22, 2024
Merged

material navigationBar's default back arrow #1228

merged 1 commit into from
Sep 22, 2024

Conversation

Kunal22shah
Copy link
Contributor

GitHub Issue (If applicable): closes #1227

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Kunal22shah Kunal22shah requested a review from kazo0 August 21, 2024 19:15
@Kunal22shah Kunal22shah self-assigned this Aug 21, 2024
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@kazo0 kazo0 mentioned this pull request Aug 23, 2024
Closed
@Kunal22shah Kunal22shah requested a review from kazo0 August 28, 2024 15:38
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@Kunal22shah Kunal22shah requested a review from kazo0 September 4, 2024 15:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@kazo0
Copy link
Contributor

kazo0 commented Sep 7, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kazo0
Copy link
Contributor

kazo0 commented Sep 9, 2024 •
edited
Loading

@Kunal22shah it looks like some runtime tests for mobile platforms are failing. We may have caused an unwanted change for the mobile NavigationBar somehow.

Also, the docs validation task is failing with some linting rules: https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=138981&view=logs&j=8d2cbba1-2077-5d2d-43e2-a39c54ffcc40&t=9d24527f-9326-5d0b-e21d-74e13b624198&l=14

@kazo0 kazo0 force-pushed the dev/ks/navbar-default-backArrow branch from 8507658 to f54ea05 Compare September 14, 2024 16:28
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@kazo0 kazo0 force-pushed the dev/ks/navbar-default-backArrow branch 2 times, most recently from 0994872 to 28d6399 Compare September 16, 2024 02:40
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

4 similar comments
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@kazo0
Copy link
Contributor

kazo0 commented Sep 16, 2024

This needs to merge first: unoplatform/Uno.Themes#1473

@kazo0 kazo0 marked this pull request as draft September 16, 2024 13:04
@kazo0
Copy link
Contributor

kazo0 commented Sep 16, 2024

@Kunal22shah can you now bump uno.material to 5.3.0-dev.4 and validate it looks ok?

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@Kunal22shah
Copy link
Contributor Author

@kazo0 Done, looks good!

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@kazo0 kazo0 marked this pull request as ready for review September 16, 2024 23:53
@kazo0 kazo0 force-pushed the dev/ks/navbar-default-backArrow branch from a367c0a to d70f067 Compare September 19, 2024 15:29
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@kazo0
Copy link
Contributor

kazo0 commented Sep 20, 2024

@Mergifyio backport release/stable/6.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 20, 2024 •
edited
Loading

backport release/stable/6.2

✅ Backports have been created

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@Kunal22shah @kazo0
chore: material default back arrow
5b80d9b 
chore: TemplateBind the Data to the Content prop

chore: fixing white spaces + updating docs

docs: fixing linter error

chore: bump Uno.Material to 5.3.0-dev.4

chore: material default back arrow

chore: TemplateBind the Data to the Content prop

chore: fixing white spaces + updating docs

docs: fixing linter error

chore: Uno.Material.WinUI 5.3.0-dev.4

chore: material default back arrow

chore: TemplateBind the Data to the Content prop

chore: fixing white spaces + updating docs

docs: fixing linter error

chore: bump Uno.Material to 5.3.0-dev.4

docs: fixing linter error

chore: Uno.Material.WinUI 5.3.0-dev.4

chore: undo material bump

chore: bump sample packages

chore: remove content setter
@kazo0 kazo0 force-pushed the dev/ks/navbar-default-backArrow branch from 8f48f00 to 5b80d9b Compare September 22, 2024 18:37
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1228.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) September 22, 2024 19:21
@kazo0 kazo0 merged commit 57206f4 into main Sep 22, 2024
29 checks passed
@kazo0 kazo0 deleted the dev/ks/navbar-default-backArrow branch September 22, 2024 19:27
mergify bot pushed a commit that referenced this pull request Sep 22, 2024
@Kunal22shah @mergify
material navigationBar's default back arrow (#1228)
e161dd0 
(cherry picked from commit 57206f4)

# Conflicts:
#	samples/Directory.Packages.props
@mergify mergify bot mentioned this pull request Sep 22, 2024
Merged
18 tasks
kazo0 added a commit that referenced this pull request Sep 23, 2024
@mergify @Kunal22shah @kazo0
material navigationBar's default back arrow (backport #1228) (#1254)
a79e83c 
Co-authored-by: Kunal Shah <37922021+Kunal22shah@users.noreply.github.com>
Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
@kazo0 kazo0 mentioned this pull request Sep 30, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

Assignees

@Kunal22shah Kunal22shah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Material] Default NavigationBar's MainCommand with a PathIcon for a back arrow
2 participants
@Kunal22shah @kazo0