Skip to content

Commit

Permalink
chore: Restore disabled tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jeromelaban authored Nov 3, 2023
1 parent 76fb4a3 commit 287cc4b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 13 deletions.
3 changes: 1 addition & 2 deletions src/Uno.Toolkit.RuntimeTests/Tests/NavigationBarTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ namespace Uno.Toolkit.RuntimeTests.Tests
internal partial class NavigationBarTests
{
[TestMethod]
// Disabled https://github.com/unoplatform/uno.toolkit.ui/issues/887
// [DataRow(MainCommandMode.Back, DisplayName = nameof(MainCommandMode.Back))]
[DataRow(MainCommandMode.Back, DisplayName = nameof(MainCommandMode.Back))]
[DataRow(MainCommandMode.Action, DisplayName = nameof(MainCommandMode.Action))]
public async Task MainCommand_In_Popup_Without_Page(MainCommandMode mainCommandMode)
{
Expand Down
19 changes: 8 additions & 11 deletions src/Uno.Toolkit.RuntimeTests/Tests/TabBarTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,13 @@ double GetTestCoordinate(Windows.Foundation.Point testPoint)
[DataRow(Orientation.Horizontal, new[] { 0, 50, 0, 0 }, DisplayName = "Horizontal at [0,50,0,0]")]
[DataRow(Orientation.Horizontal, new[] { 0, 0, 0, 50 }, DisplayName = "Horizontal at [0,0,0,50]")]
[DataRow(Orientation.Horizontal, new[] { 0, 30, 0, 20 }, DisplayName = "Horizontal at [0,30,0,20]")]
// Disabled for https://github.com/unoplatform/uno.toolkit.ui/issues/887
// [DataRow(Orientation.Vertical, new[] { 0, 0, 0, 0 }, DisplayName = "Vertical at [0,0,0,0]")]
// [DataRow(Orientation.Vertical, new[] { 30, 0, 0, 0 }, DisplayName = "Vertical at [30,0,0,0]")]
// [DataRow(Orientation.Vertical, new[] { 0, 0, 30, 0 }, DisplayName = "Vertical at [0,0,30,0]")]
// [DataRow(Orientation.Vertical, new[] { 30, 0, 30, 0 }, DisplayName = "Vertical at [30,0,30,0]")]
// [DataRow(Orientation.Vertical, new[] { 50, 0, 0, 0 }, DisplayName = "Vertical at [50,0,0,0]")]
// [DataRow(Orientation.Vertical, new[] { 0, 0, 50, 0 }, DisplayName = "Vertical at [0,0,50,0]")]
// [DataRow(Orientation.Vertical, new[] { 30, 0, 20, 0 }, DisplayName = "Vertical at [30,0,20,0]")]
[DataRow(Orientation.Vertical, new[] { 0, 0, 0, 0 }, DisplayName = "Vertical at [0,0,0,0]")]
[DataRow(Orientation.Vertical, new[] { 30, 0, 0, 0 }, DisplayName = "Vertical at [30,0,0,0]")]
[DataRow(Orientation.Vertical, new[] { 0, 0, 30, 0 }, DisplayName = "Vertical at [0,0,30,0]")]
[DataRow(Orientation.Vertical, new[] { 30, 0, 30, 0 }, DisplayName = "Vertical at [30,0,30,0]")]
[DataRow(Orientation.Vertical, new[] { 50, 0, 0, 0 }, DisplayName = "Vertical at [50,0,0,0]")]
[DataRow(Orientation.Vertical, new[] { 0, 0, 50, 0 }, DisplayName = "Vertical at [0,0,50,0]")]
[DataRow(Orientation.Vertical, new[] { 30, 0, 20, 0 }, DisplayName = "Vertical at [30,0,20,0]")]
public async Task Verify_Padding(
Orientation orientation,
int[] padding)
Expand Down Expand Up @@ -271,7 +270,6 @@ double GetMinCalculatedDimen()
}

[TestMethod]
[Ignore("Disabled https://github.com/unoplatform/uno.toolkit.ui/issues/887")]
public async Task Verify_Indicator_Display_On_Selection()
{
if (!ImageAssertHelper.IsScreenshotSupported())
Expand Down Expand Up @@ -335,8 +333,7 @@ TabBarItem CreateItem()

[TestMethod]
[DataRow(IndicatorPlacement.Above, DisplayName = "Verify Indicator Above")]
// Disabled https://github.com/unoplatform/uno.toolkit.ui/issues/887
// [DataRow(IndicatorPlacement.Below, DisplayName = "Verify Indicator Below")]
[DataRow(IndicatorPlacement.Below, DisplayName = "Verify Indicator Below")]
public async Task Verify_Indicator_Placement(IndicatorPlacement placement)
{
var item = new TabBarItem
Expand Down

0 comments on commit 287cc4b

Please sign in to comment.