Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(reactive): Fix support of runtime tests in feeds testing library #994

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Dec 13, 2022

GitHub Issue (If applicable): #

PR Type

  • Bugfix: Fix support of runtime tests in feeds testing library
  • Refactoring: move UI related tests to runtime tests

What is the current behavior?

The base class FeedTests relies on the TestContext that is not yet supported by runtime tests engine

What is the new behavior?

FeedTests allow null-ref for the TestContext

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb self-assigned this Dec 13, 2022
@dr1rrb dr1rrb enabled auto-merge December 13, 2022 15:43
@dr1rrb
Copy link
Member Author

dr1rrb commented Dec 13, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dr1rrb dr1rrb merged commit 499a214 into main Dec 14, 2022
@dr1rrb dr1rrb deleted the dev/dr/mvUItests branch December 14, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants