Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preventing recreation of pages when navigating back #973

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Dec 7, 2022

GitHub Issue (If applicable): https://github.com/unoplatform/uno.chefs/issues/105

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When navigating back with a return value the previous page was being recreated, even if NavigationCacheMode set to Required (on Android)

[Also, on Xamarin Android an exception is raised when using Console logging]

What is the new behavior?

Removed code that was modifying the backstack - this is only used when retrieving the response value in the NavigatedTo event in the previous page - it's not used by Uno.Ext.Navigation, so removing this will not affect existing functionality.

[Also, removed console logging for Xamarin targets, and fixed build for the Legacy targets for testharness]

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • [ N/A ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • [ N/A ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • [ N/A ] Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph marked this pull request as ready for review December 7, 2022 04:23
@nickrandolph nickrandolph merged commit 1e3c16e into main Dec 7, 2022
@nickrandolph nickrandolph deleted the dev/nr/navbackissue branch December 7, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants