Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(reactive): Allow generation of VM on non UI assembly #917

Merged
merged 11 commits into from
Nov 17, 2022
Merged

feat(reactive): Allow generation of VM on non UI assembly #917

merged 11 commits into from
Nov 17, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Nov 14, 2022 •
edited
Loading

closes #917

Feature

Allow generation of VM on non UI assembly

What is the current behavior?

Generated code depends on Uno / UWP / WinUI's dispatcher

What is the new behavior?

The generated code non longer depends on dispatcher

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb force-pushed the dev/dr/corePresentation branch from ab6be86 to bd9afe2 Compare November 15, 2022 15:53
@dr1rrb dr1rrb enabled auto-merge November 16, 2022 00:05
@dr1rrb dr1rrb force-pushed the dev/dr/corePresentation branch from 95cfcb9 to dd5bb81 Compare November 17, 2022 16:19
@dr1rrb
chore: Remove old file header from fast async sync lock
a7fcce6 
This has removal has been approved by nventive
carldebilly
carldebilly approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@carldebilly carldebilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;JA

@dr1rrb dr1rrb merged commit 9e77ddf into main Nov 17, 2022
@dr1rrb dr1rrb deleted the dev/dr/corePresentation branch November 17, 2022 21:58
@dr1rrb dr1rrb mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrandolph nickrandolph nickrandolph left review comments

@carldebilly carldebilly carldebilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dr1rrb @nickrandolph @carldebilly