Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactoring navigation #906

Merged
merged 16 commits into from
Nov 14, 2022
Merged

chore: Refactoring navigation #906

merged 16 commits into from
Nov 14, 2022

Conversation

nickrandolph
Copy link
Contributor

Refactoring navigation to make easier to understand

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

Base automatically changed from dev/nr/perftimer to main November 10, 2022 02:19
@nickrandolph nickrandolph force-pushed the dev/nr/navrefactor branch 3 times, most recently from fcbcbf7 to d63b340 Compare November 11, 2022 04:56
@nickrandolph nickrandolph merged commit d5be9c4 into main Nov 14, 2022
@nickrandolph nickrandolph deleted the dev/nr/navrefactor branch November 14, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoistanguay francoistanguay francoistanguay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickrandolph @francoistanguay