Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Including Model in view model suffix #882

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

nickrandolph
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

ViewModels need to end with VM or ViewModel

What is the new behavior?

ViewModels can end with VM, ViewModel or Model to allow for a shift towards reactive models instead of viewmodels

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit 4f90d1b into main Nov 2, 2022
@nickrandolph nickrandolph deleted the dev/nr/modelsuffix branch November 2, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants