Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(feed): Doc for 2.3 release #879

Merged
merged 4 commits into from
Oct 31, 2022
Merged

docs(feed): Doc for 2.3 release #879

merged 4 commits into from
Oct 31, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Oct 31, 2022

Documentation content changes

Update doc for Model vs ViewModel + Selection support

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

jeromelaban
jeromelaban approved these changes Oct 31, 2022
View reviewed changes
doc/Overview/Reactive/in-apps.md Show resolved Hide resolved
doc/Overview/Reactive/in-apps.md Outdated Show resolved Hide resolved
doc/Overview/Reactive/in-apps.md Outdated Show resolved Hide resolved
doc/Overview/Reactive/in-apps.md Outdated Show resolved Hide resolved
doc/Overview/Reactive/in-apps.md Outdated Show resolved Hide resolved
doc/Overview/Reactive/in-apps.md Outdated Show resolved Hide resolved
doc/Overview/Reactive/in-apps.md Outdated Show resolved Hide resolved
doc/Overview/Reactive/in-apps.md Outdated Show resolved Hide resolved
doc/Overview/Reactive/in-apps.md Outdated Show resolved Hide resolved
doc/Overview/Reactive/in-apps.md Outdated Show resolved Hide resolved
@dr1rrb @jeromelaban
fix: Apply suggestions from code review
456e7f9 
Co-authored-by: Jérôme Laban <jerome.laban@nventive.com>
@dr1rrb dr1rrb enabled auto-merge October 31, 2022 21:12
@dr1rrb dr1rrb merged commit 97f9cca into main Oct 31, 2022
@dr1rrb dr1rrb deleted the dev/dr/docsModel branch October 31, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr1rrb @jeromelaban