Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feeds): Add ability to generate [Bindable]VM from Model instead of ViewModel #868

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Oct 28, 2022

Note: this is draft until #860 is merged

Feature

Add ability to generate [Bindable]VM from Model instead

What is the current behavior?

The implicit generation occurs only if you suffix your class by ViewModel

What is the new behavior?

This is now configurable

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb marked this pull request as ready for review October 28, 2022 17:38
@dr1rrb dr1rrb enabled auto-merge October 28, 2022 18:56
@dr1rrb dr1rrb disabled auto-merge October 28, 2022 20:36
@dr1rrb dr1rrb merged commit 958c420 into main Oct 28, 2022
@dr1rrb dr1rrb deleted the dev/dr/vmToModel branch October 28, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant