Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor TFMs for extensions #798

Merged
merged 3 commits into from
Oct 18, 2022
Merged

feat: Refactor TFMs for extensions #798

merged 3 commits into from
Oct 18, 2022

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Oct 7, 2022 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Each project has its own set of TFS specified

What is the new behavior?

Simplify management of TFS across the extension projects using separate targets files for uwp and winui

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph force-pushed the dev/nr/tfmrefactor branch 2 times, most recently from 54629a7 to f524eab Compare October 10, 2022 12:44
@nickrandolph nickrandolph force-pushed the dev/nr/tfmrefactor branch 3 times, most recently from c02b757 to ba00963 Compare October 18, 2022 05:43
@nickrandolph nickrandolph marked this pull request as ready for review October 18, 2022 06:49
dr1rrb
dr1rrb reviewed Oct 18, 2022
View reviewed changes
src/tfms-all.props Outdated Show resolved Hide resolved
@nickrandolph nickrandolph merged commit de6a73a into main Oct 18, 2022
@nickrandolph nickrandolph deleted the dev/nr/tfmrefactor branch October 18, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr1rrb dr1rrb dr1rrb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickrandolph @dr1rrb