Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(feeds): Improve ability to test Bindable<T> #773

Merged
merged 1 commit into from
Sep 28, 2022
Merged

test(feeds): Improve ability to test Bindable<T> #773

merged 1 commit into from
Sep 28, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Sep 28, 2022

Feature

Improve ability to test Bindable

What is the current behavior?

There is no helper to test Bindable and there is actually no UI thread while in tests.

What is the new behavior?

🙃

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb self-assigned this Sep 28, 2022
@dr1rrb dr1rrb enabled auto-merge September 28, 2022 14:11
@dr1rrb dr1rrb merged commit 6766ce9 into main Sep 28, 2022
@dr1rrb dr1rrb deleted the dev/dr/testBindable branch September 28, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@carldebilly carldebilly carldebilly approved these changes

Assignees

@dr1rrb dr1rrb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dr1rrb @carldebilly @jeromelaban