Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feeds): Entity tracking in list feeds #759

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Sep 23, 2022

linked to #688

Feature

Entity tracking in list feeds

What is the current behavior?

We rely only on Equals to track entities in messages of ListFeed. This cause the UI to animate remove + add when we update an entity in a ListState

What is the new behavior?

We are using the generated key equality to properly track entities

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features) comming with last PR for this feature
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb enabled auto-merge September 24, 2022 01:29
@dr1rrb dr1rrb self-assigned this Sep 27, 2022
@dr1rrb dr1rrb merged commit 31142a1 into main Sep 27, 2022
@dr1rrb dr1rrb deleted the dev/dr/lfEntityTracking branch September 27, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants