fix: Prevent Cleared event being raised when there aren't any tokens

src/Uno.Extensions.Authentication/AuthenticationService.cs

@@ -53,6 +53,9 @@ public async ValueTask<bool> LogoutAsync(IDispatcher? dispatcher, CancellationTo
 
 		if (_logger.IsEnabled(LogLevel.Trace)) _logger.LogTraceMessage($"Logout successful, so clear token cache");
 		await _tokens.ClearAsync(ct);
+
+		// Don't raise LoggedOut event here - if there were tokens, then the ITokenCache.Cleared event will
+		// be raised, which in turn will trigger the LoggedOut event to be raised
 		return true;
 	}
 

src/Uno.Extensions.Authentication/Handlers/BaseAuthorizationHandler.cs

@@ -92,8 +92,8 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
 				{
 					if (_logger.IsEnabled(LogLevel.Debug)) _logger.LogDebugMessage($"The request '{request.RequestUri}' was unauthorized and the tokens cannot be refreshed. Considering the session has expired.");
 
-			// Request was unauthorized and we cannot refresh the authentication token.
-			await _tokens.ClearAsync(ct);
+					// Request was unauthorized and we cannot refresh the authentication token.
+					await _tokens.ClearAsync(ct);
 
 					return response;
 				}
@@ -104,8 +104,8 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
 				{
 					if (_logger.IsEnabled(LogLevel.Debug)) _logger.LogDebugMessage($"The request '{request.RequestUri}' was unauthorized and the token failed to refresh. Considering the session has expired.");
 
-			// No authentication token to use.
-			await _tokens.ClearAsync(ct);
+					// No authentication token to use.
+					await _tokens.ClearAsync(ct);
 
 					return response;
 				}
@@ -159,7 +159,7 @@ protected virtual async Task<bool> RefreshAuthenticationToken(CancellationToken
 		{
 			return await _authenticationService.RefreshAsync(ct);
 		}
-		catch(Exception ex)
+		catch (Exception ex)
 		{
 			if (_logger.IsEnabled(LogLevel.Debug)) _logger.LogDebugMessage($"Error refreshing token - {ex.Message}");
 			return false;

src/Uno.Extensions.Authentication/TokenCache.cs

@@ -33,17 +33,23 @@ public TokenCache(
 	public async ValueTask ClearAsync(CancellationToken cancellation)
 	{
 		if (_logger.IsEnabled(LogLevel.Trace)) _logger.LogTraceMessage("Clearing tokens by invoking SaveAsync with empty dictionary");
-		// Don't acquire lock since this is done in the Save method
+		// Don't acquire lock since this is done in the Get/Save methods respectively
+		var existingTokens = await GetAsync(cancellation);
 		await SaveAsync(string.Empty, new Dictionary<string, string>(), cancellation);
 		if (_logger.IsEnabled(LogLevel.Trace)) _logger.LogTraceMessage("Tokens cleared");
-		try
-		{
-			if (_logger.IsEnabled(LogLevel.Trace)) _logger.LogTraceMessage("Raising Cleared event");
-			Cleared?.Invoke(this, EventArgs.Empty);
-		}
-		catch (Exception ex)
+		if (existingTokens.Any())
 		{
-			if (_logger.IsEnabled(LogLevel.Error)) _logger.LogErrorMessage($"Error raising Cleared event - check listeners to fix errors handling this event {ex.Message}");
+			// Only triggered cleared event if there were actually tokens to be cleared
+			// This prevents Cleared being raised when the user isn't logged in
+			try
+			{
+				if (_logger.IsEnabled(LogLevel.Trace)) _logger.LogTraceMessage("Raising Cleared event");
+				Cleared?.Invoke(this, EventArgs.Empty);
+			}
+			catch (Exception ex)
+			{
+				if (_logger.IsEnabled(LogLevel.Error)) _logger.LogErrorMessage($"Error raising Cleared event - check listeners to fix errors handling this event {ex.Message}");
+			}
 		}
 	}