Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feeds): Fix possible invalid generated code when using ValueType parameter #729

Merged
merged 1 commit into from
Sep 14, 2022
Merged

fix(feeds): Fix possible invalid generated code when using ValueType parameter #729

merged 1 commit into from
Sep 14, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Sep 14, 2022

fixes #728

Bugfix

Fix possible invalid generated code when using ValueType parameter

What is the current behavior?

We check for null using pattern matching, including for ValueType and Nullable<T>

What is the new behavior?

  • We don't check for null for ValueType
  • We don't use pattern matching anymore (not allowed for Nullable<T>, and required an higher version of C# than we should)

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb self-assigned this Sep 14, 2022
@dr1rrb dr1rrb enabled auto-merge September 14, 2022 17:12
@github-actions
Copy link

github-actions bot commented Sep 14, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-729.eastus2.azurestaticapps.net

@dr1rrb dr1rrb merged commit 7413729 into main Sep 14, 2022
@dr1rrb dr1rrb deleted the dev/dr/commandsMiscIssues branch September 14, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte approved these changes

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees

@dr1rrb dr1rrb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Reactive] Invalid generated code when using a ValueType as command parameter
3 participants
@dr1rrb @jeromelaban @agneszitte