Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Refactoring MVUX Docs #2538

Merged
merged 21 commits into from
Sep 19, 2024
Merged

Docs: Refactoring MVUX Docs #2538

merged 21 commits into from
Sep 19, 2024

Conversation

vatsashah45
Copy link
Contributor

@vatsashah45 vatsashah45 commented Sep 3, 2024

GitHub Issue (If applicable): closes #2434

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Kunal22shah Kunal22shah marked this pull request as draft September 3, 2024 14:10
doc/Reference/Reactive/feed.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/feed.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/feed.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/feed.md Show resolved Hide resolved
doc/Reference/Reactive/feed.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/state.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/state.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/state.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/state.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/state.md Outdated Show resolved Hide resolved
@kazo0
Copy link
Contributor

kazo0 commented Sep 6, 2024

@vatsashah45 there are a bunch of formatting issues that are getting flagged by the linter: dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=138732&view=logs&j=8d2cbba1-2077-5d2d-43e2-a39c54ffcc40&t=9d24527f-9326-5d0b-e21d-74e13b624198

You'll need to address all of those before this can merge

@vatsashah45 vatsashah45 marked this pull request as ready for review September 9, 2024 14:49
doc/Reference/Reactive/feed.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/listfeed.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/state.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/state.md Outdated Show resolved Hide resolved
doc/Reference/Reactive/state.md Show resolved Hide resolved
@vatsashah45 vatsashah45 requested a review from dr1rrb September 19, 2024 14:56
@kazo0 kazo0 enabled auto-merge September 19, 2024 15:08
@kazo0 kazo0 merged commit 7263ac3 into main Sep 19, 2024
9 of 10 checks passed
@kazo0 kazo0 deleted the dev/ks/vs/update-MVUX-docs branch September 19, 2024 15:50
@agneszitte
Copy link
Contributor

@kazo0 should be backported to release/stable/5.0 no ?

@kazo0
Copy link
Contributor

kazo0 commented Sep 26, 2024

@Mergifyio backport release/stable/5.0

Copy link

mergify bot commented Sep 26, 2024

backport release/stable/5.0

❌ No backport have been created

  • Backport to branch release/stable/5.0 failed

Git reported the following error:

error: commit a979e00b90477463be3ca804f69f27f3977b65b0 is a merge but no -m option was given.
fatal: cherry-pick failed

@kazo0
Copy link
Contributor

kazo0 commented Sep 26, 2024

@Mergifyio backport release/stable/5.0

Copy link

mergify bot commented Sep 26, 2024

backport release/stable/5.0

❌ No backport have been created

  • Backport to branch release/stable/5.0 failed

Git reported the following error:

error: commit a979e00b90477463be3ca804f69f27f3977b65b0 is a merge but no -m option was given.
fatal: cherry-pick failed

agneszitte added a commit that referenced this pull request Sep 26, 2024
…5.0/pr-2538

Docs: Refactoring MVUX Docs #2538 (backport)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs][MVUX][EPIC] Improve documentation + create sample
6 participants