fix: Only update addressbar on wasm #2529

eriklimakc · 2024-08-26T12:37:54Z

GitHub Issue (If applicable): closes #2511

PR Type

What kind of change does this PR introduce?

Address bar code being executed on other platforms.

Address bar code being executed only on Wasm.

Please check if your PR fulfills the following requirements:

Tested code with current supported SDKs
Docs have been added/updated which fit documentation template. (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
Contains NO breaking changes
Updated the Release Notes
Associated with an issue (GitHub or internal)

Internal Issue (If applicable):

eriklimakc requested a review from nickrandolph August 26, 2024 12:37

eriklimakc self-assigned this Aug 26, 2024

eriklimakc marked this pull request as ready for review August 26, 2024 13:29

eriklimakc force-pushed the dev/erli/2511-addressbarwarnings branch from 889842c to a63376f Compare August 26, 2024 15:05

fix: Only update addressbar on wasm

2f2827e

eriklimakc force-pushed the dev/erli/2511-addressbarwarnings branch from a63376f to 2f2827e Compare August 26, 2024 15:06

chore: Only warn missing view if path is not empty

aa8208f

nickrandolph approved these changes Aug 27, 2024

View reviewed changes

nickrandolph merged commit 09fb50b into main Aug 27, 2024
14 of 15 checks passed

nickrandolph deleted the dev/erli/2511-addressbarwarnings branch August 27, 2024 13:21