Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: App blanks out when navigating to invalid route #2517

Merged
merged 7 commits into from
Aug 22, 2024
Merged

fix: App blanks out when navigating to invalid route #2517

merged 7 commits into from
Aug 22, 2024

Conversation

vatsashah45
Copy link
Contributor

GitHub Issue (If applicable): closes #2382

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@vatsashah45 vatsashah45 self-assigned this Aug 21, 2024
@vatsashah45 vatsashah45 marked this pull request as draft August 21, 2024 16:17
@vatsashah45 vatsashah45 marked this pull request as ready for review August 21, 2024 19:10
@vatsashah45 vatsashah45 requested a review from kazo0 August 22, 2024 20:13
@kazo0 kazo0 enabled auto-merge August 22, 2024 21:42
@kazo0 kazo0 merged commit 76a8f4d into main Aug 22, 2024
14 of 15 checks passed
@kazo0 kazo0 deleted the dev/vs/invalid-route-navigation branch August 22, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriklimakc eriklimakc eriklimakc approved these changes

@kazo0 kazo0 kazo0 approved these changes

@Kunal22shah Kunal22shah Awaiting requested review from Kunal22shah

Assignees

@vatsashah45 vatsashah45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Layout Blanks Out When Navigating to Invalid Route
3 participants
@vatsashah45 @kazo0 @eriklimakc