Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Data not saving #2471

Merged
merged 5 commits into from
Sep 6, 2024
Merged

fix: Data not saving #2471

merged 5 commits into from
Sep 6, 2024

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): closes #2470

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Tokens are saved with the wrong key

What is the new behavior?

Tokens are saved/retrieved with the correct key

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph enabled auto-merge July 28, 2024 16:50
Copy link
Contributor

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... but would like to see some tests

@eriklimakc eriklimakc force-pushed the dev/nr/authnotsaving branch from 048786a to 9b9f873 Compare July 31, 2024 15:53
@kazo0
Copy link
Contributor

kazo0 commented Aug 20, 2024

@eriklimakc what happens without this change if you were to perform a login and then a logout and call Authentication.RefreshAsync?

@eriklimakc eriklimakc force-pushed the dev/nr/authnotsaving branch from 9b9f873 to e5a745e Compare August 23, 2024 10:41
@nickrandolph nickrandolph merged commit f3250ed into main Sep 6, 2024
14 of 15 checks passed
@nickrandolph nickrandolph deleted the dev/nr/authnotsaving branch September 6, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokens can't be retrieved after successful login
4 participants