Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check if navigating back is possible to update state #2462

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

eriklimakc
Copy link
Contributor

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When navigating back to the first/main page the url doesn't update.

What is the new behavior?

The URL now updates properly.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@eriklimakc eriklimakc force-pushed the dev/erli/fix-addressbar-url-wasm branch from c45c82f to 81f85fa Compare July 26, 2024 13:25
@eriklimakc eriklimakc force-pushed the dev/erli/fix-addressbar-url-wasm branch from 81f85fa to de9db87 Compare July 26, 2024 13:43
@kazo0
Copy link
Contributor

kazo0 commented Jul 26, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eriklimakc eriklimakc requested a review from nickrandolph July 29, 2024 10:23
@nickrandolph nickrandolph merged commit cb1da4b into main Jul 29, 2024
16 of 17 checks passed
@nickrandolph nickrandolph deleted the dev/erli/fix-addressbar-url-wasm branch July 29, 2024 13:47
@kazo0
Copy link
Contributor

kazo0 commented Aug 6, 2024

@Mergifyio backport release/stable/4.2

Copy link

mergify bot commented Aug 6, 2024

backport release/stable/4.2

✅ Backports have been created

kazo0 added a commit that referenced this pull request Aug 8, 2024
….2/pr-2462

fix: Check if navigating back is possible to update state (backport #2462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants