Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initialize Windows localSelection #2457

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix: initialize Windows localSelection #2457

merged 2 commits into from
Aug 5, 2024

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented Jul 24, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #2473

PR Type

What kind of change does this PR introduce?

  • Bugfix

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@rajamatt rajamatt self-assigned this Jul 24, 2024
@rajamatt rajamatt force-pushed the dev/mara/ir-selection-info branch from 8fef72b to 724d6e1 Compare July 24, 2024 19:40
@rajamatt rajamatt marked this pull request as ready for review August 5, 2024 18:07
@rajamatt rajamatt requested a review from kazo0 August 5, 2024 18:07
@kazo0 kazo0 merged commit bc1e4d2 into main Aug 5, 2024
14 of 15 checks passed
@kazo0 kazo0 deleted the dev/mara/ir-selection-info branch August 5, 2024 19:26
@kazo0
Copy link
Contributor

kazo0 commented Aug 6, 2024

@Mergifyio backport release/stable/4.2

@mergify Mergify
Copy link

mergify bot commented Aug 6, 2024 •
edited
Loading

backport release/stable/4.2

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 6, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

Assignees

@rajamatt rajamatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] SelectionInfo localSelection isn't set when constructing
2 participants
@rajamatt @kazo0