Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent FrameView DataContext propagation #2451

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

eriklimakc
Copy link
Contributor

@eriklimakc eriklimakc commented Jul 22, 2024

GitHub Issue (If applicable): closes #2522

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

FrameView would inherit DataContext from parents and propagate it to child pages.

What is the new behavior?

Set FrameView.DataContext to null to avoid DataContext inheritance and propagation.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@eriklimakc eriklimakc requested a review from nickrandolph July 22, 2024 14:47
@eriklimakc eriklimakc self-assigned this Jul 22, 2024
@eriklimakc eriklimakc force-pushed the dev/erli/prevent-frameview-vm-propagation branch from c59823c to c33df02 Compare August 12, 2024 16:10
@eriklimakc eriklimakc force-pushed the dev/erli/prevent-frameview-vm-propagation branch 2 times, most recently from d242cec to f860aa2 Compare August 22, 2024 16:20
@eriklimakc eriklimakc force-pushed the dev/erli/prevent-frameview-vm-propagation branch from f860aa2 to aff57c6 Compare August 23, 2024 10:00
@eriklimakc eriklimakc merged commit c2c2541 into main Aug 23, 2024
14 of 15 checks passed
@eriklimakc eriklimakc deleted the dev/erli/prevent-frameview-vm-propagation branch August 23, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FrameView propagates DataContext to child elements
3 participants