Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unnecessary request segments from parent region in backstack #2409

Merged
merged 5 commits into from
Aug 9, 2024
Merged

fix: Remove unnecessary request segments from parent region in backstack #2409

merged 5 commits into from
Aug 9, 2024

Conversation

eriklimakc
Copy link
Contributor

@eriklimakc eriklimakc commented Jul 3, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #2505

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@eriklimakc eriklimakc changed the title chore: Add regions app fix: Remove unnecessary request segments from parent region in backstack Jul 5, 2024
@eriklimakc eriklimakc force-pushed the dev/erli/region-sample branch from acfba69 to d39d232 Compare July 8, 2024 11:03
@eriklimakc eriklimakc mentioned this pull request Jul 9, 2024
Open
1 task
@eriklimakc eriklimakc marked this pull request as ready for review July 19, 2024 14:01
@eriklimakc eriklimakc force-pushed the dev/erli/region-sample branch from 485d568 to 456909e Compare July 19, 2024 14:09
@eriklimakc eriklimakc requested a review from nickrandolph July 19, 2024 14:10
@eriklimakc eriklimakc marked this pull request as draft August 8, 2024 14:58
@eriklimakc eriklimakc force-pushed the dev/erli/region-sample branch from 456909e to 60c70ff Compare August 8, 2024 14:58
@eriklimakc eriklimakc marked this pull request as ready for review August 8, 2024 15:11
@eriklimakc eriklimakc requested a review from kazo0 August 8, 2024 15:11
@eriklimakc eriklimakc merged commit f677bd2 into main Aug 9, 2024
14 of 15 checks passed
@eriklimakc eriklimakc deleted the dev/erli/region-sample branch August 9, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

@nickrandolph nickrandolph Awaiting requested review from nickrandolph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ContentControl navigation generates improper back navigation
3 participants
@eriklimakc @kazo0 @nickrandolph