Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Using simple settings as alternative for key-value store when ApplicationData isn't available #2373

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): closes #2241

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Accessing ApplicationData when running unpackaged on Windows throws an exception

What is the new behavior?

ISettings is used as a fallback for when ApplicaitonData isn't available

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

Co-authored-by: Carl de Billy <carl.debilly@nventive.com>
@nickrandolph nickrandolph merged commit e8d0bae into main Jun 24, 2024
16 of 17 checks passed
@nickrandolph nickrandolph deleted the dev/nr/oidc branch June 24, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Windows - CustomApp - Operation is not valid due to the current state of the object.
3 participants