Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include FooterMenuItems to NavigationMenuItems #2345

Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix: Include FooterMenuItems to NavigationMenuItems #2345

merged 2 commits into from
Jun 20, 2024

Conversation

eriklimakc
Copy link
Contributor

@eriklimakc eriklimakc commented Jun 12, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #2300

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

FooterMenuItems are not included in NavigationMenuItems, which wouldn't allow FooterMenuItems to work properly with Navigation.

What is the new behavior?

Adding FooterMenuItems to NavigationMenuItems

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@eriklimakc eriklimakc requested a review from nickrandolph June 12, 2024 17:57
@eriklimakc eriklimakc self-assigned this Jun 12, 2024
@nickrandolph nickrandolph force-pushed the dev/erli/2300-include-footer-menu-item branch from 0f5c160 to d041029 Compare June 19, 2024 15:41
@nickrandolph nickrandolph enabled auto-merge June 19, 2024 15:42
@nickrandolph nickrandolph merged commit 76c3d64 into main Jun 20, 2024
16 of 17 checks passed
@nickrandolph nickrandolph deleted the dev/erli/2300-include-footer-menu-item branch June 20, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 left review comments

@kazo0 kazo0 kazo0 approved these changes

@nickrandolph nickrandolph nickrandolph approved these changes

@jeromelaban jeromelaban Awaiting requested review from jeromelaban

@Youssef1313 Youssef1313 Awaiting requested review from Youssef1313

Assignees

@eriklimakc eriklimakc

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@eriklimakc @nickrandolph @Xiaoy312 @kazo0