Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update existing reference navigation docs #2320

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

eriklimakc
Copy link
Contributor

GitHub Issue (If applicable): closes #2298

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

Unpublished documention regarding "Reference/Navigation"

What is the new behavior?

Reviewed and updated documentation regarding "Reference/Navigation" to publish.

@eriklimakc eriklimakc added the kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project label Jun 4, 2024
@eriklimakc eriklimakc self-assigned this Jun 4, 2024
doc/Reference/Navigation/Design.md Outdated Show resolved Hide resolved
doc/Reference/Navigation/Design.md Outdated Show resolved Hide resolved
doc/Reference/Navigation/Qualifiers.md Outdated Show resolved Hide resolved
doc/Reference/Navigation/Qualifiers.md Outdated Show resolved Hide resolved
doc/Reference/Navigation/Qualifiers.md Outdated Show resolved Hide resolved
doc/Reference/Navigation/ViewMap.md Outdated Show resolved Hide resolved
@eriklimakc eriklimakc force-pushed the dev/erli/2298-update-reference-navigation-docs branch from 1d1288c to c017bc3 Compare June 5, 2024 12:26
@eriklimakc eriklimakc marked this pull request as ready for review June 5, 2024 12:28
@eriklimakc eriklimakc force-pushed the dev/erli/2298-update-reference-navigation-docs branch from c017bc3 to fe41416 Compare June 13, 2024 16:46
@eriklimakc
Copy link
Contributor Author

Rebased to include #2343

@eriklimakc eriklimakc force-pushed the dev/erli/2298-update-reference-navigation-docs branch 3 times, most recently from 28b8201 to 327272a Compare June 14, 2024 18:37
@eriklimakc eriklimakc force-pushed the dev/erli/2298-update-reference-navigation-docs branch from 327272a to 6526919 Compare July 1, 2024 16:10
@eriklimakc
Copy link
Contributor Author

ViewMap and RouteMap pages were removed from the Reference folder since we are introducing ViewMap and RouteMap on #2317.

@agneszitte
Copy link
Contributor

agneszitte commented Sep 4, 2024

@eriklimakc what is the status of this PR please ? (based on latest)

@eriklimakc
Copy link
Contributor Author

@eriklimakc what is the status of this PR please ? (based on latest)

@agneszitte I need to figure out how NavigationRequestHandler works to properly document it. #2320 (comment)

@kazo0
Copy link
Contributor

kazo0 commented Sep 6, 2024

@eriklimakc should this be moved to draft or can it merge as is?

@eriklimakc eriklimakc marked this pull request as draft September 9, 2024 11:27
@eriklimakc eriklimakc force-pushed the dev/erli/2298-update-reference-navigation-docs branch 5 times, most recently from fde8f25 to 46b2d7f Compare September 16, 2024 12:27
@eriklimakc eriklimakc marked this pull request as ready for review September 16, 2024 12:33
@eriklimakc eriklimakc force-pushed the dev/erli/2298-update-reference-navigation-docs branch from 46b2d7f to f896dd0 Compare September 16, 2024 14:19
@kazo0 kazo0 merged commit 26e1bf7 into main Sep 26, 2024
9 of 10 checks passed
@kazo0 kazo0 deleted the dev/erli/2298-update-reference-navigation-docs branch September 26, 2024 15:33
@kazo0
Copy link
Contributor

kazo0 commented Sep 26, 2024

@Mergifyio backport release/stable/5.0

Copy link

mergify bot commented Sep 26, 2024

backport release/stable/5.0

✅ Backports have been created

agneszitte added a commit that referenced this pull request Sep 26, 2024
….0/pr-2320

docs: Update existing reference navigation docs (backport #2320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs][Navigation] Some documentation/details at the moment are not used in the published documentation
4 participants