Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updating navigation docs to match latest template #2314

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

eriklimakc
Copy link
Contributor

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

Many of Navigation docs still use references from older templates.

What is the new behavior?

Updating examples and references with latest template changes

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@eriklimakc eriklimakc added the kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project label May 31, 2024
@eriklimakc eriklimakc requested a review from nickrandolph May 31, 2024 12:07
@eriklimakc eriklimakc self-assigned this May 31, 2024
doc/Learn/Authentication/HowTo-Authentication.md Outdated Show resolved Hide resolved
doc/Learn/Navigation/Advanced/HowTo-UseNavigationView.md Outdated Show resolved Hide resolved
doc/Learn/Navigation/Advanced/HowTo-UseTabBar.md Outdated Show resolved Hide resolved
doc/Learn/Navigation/HowTo-NavigateInXAML.md Outdated Show resolved Hide resolved
doc/Learn/Navigation/HowTo-NavigateInXAML.md Outdated Show resolved Hide resolved
doc/Learn/Navigation/HowTo-SelectValue.md Outdated Show resolved Hide resolved
doc/Learn/Navigation/HowTo-SelectValue.md Outdated Show resolved Hide resolved
doc/Learn/Navigation/HowTo-SelectValue.md Outdated Show resolved Hide resolved
@agneszitte agneszitte requested review from dr1rrb and jeromelaban May 31, 2024 16:46
@eriklimakc eriklimakc force-pushed the dev/erli/navigation-docs branch from 64bc9f4 to 10cc111 Compare May 31, 2024 17:09
@agneszitte agneszitte requested review from kazo0 and Xiaoy312 June 4, 2024 02:01
@eriklimakc eriklimakc force-pushed the dev/erli/navigation-docs branch from 10cc111 to dbe8302 Compare June 14, 2024 14:50
@nickrandolph nickrandolph enabled auto-merge June 19, 2024 10:08
@nickrandolph
Copy link
Contributor

@eriklimakc / @agneszitte would you be able to fix the doc validations please

@eriklimakc eriklimakc force-pushed the dev/erli/navigation-docs branch 2 times, most recently from ed0d0c4 to a63cddd Compare June 24, 2024 11:20
@nickrandolph nickrandolph merged commit 80422de into main Jun 24, 2024
9 of 10 checks passed
@nickrandolph nickrandolph deleted the dev/erli/navigation-docs branch June 24, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants